Re: [PATCH v3] ip6mr: Fix skb_under_panic in ip6mr_cache_report()

From: David Ahern
Date: Tue Aug 01 2023 - 23:19:04 EST


On 8/1/23 8:10 PM, Jakub Kicinski wrote:
> On Wed, 2 Aug 2023 09:28:31 +0800 YueHaibing wrote:
>>> that pattern shows up a few times:
>>
>> Ok, I will test and fix these if any.
>
> Thanks, we may also want to add a
> DEBUG_NET_WARN_ON_ONCE(len > INT_MAX)
> in skb_push() but perhaps that's an overkill.
> Most of those cases are probably legit (skb_.*_offset()
> can well be negative if headers were already pulled).

Yea, a lot of those could be legit, so it would be best to have a test
case that shows it can be triggered and then any patch fixes it.