Re: [PATCH v1 2/2] arm64: dts: ti: k3-am625-verdin: enable CAN_2

From: Nishanth Menon
Date: Tue Aug 01 2023 - 23:43:47 EST


On 15:36-20230724, Francesco Dolcini wrote:
[...]

> + /* Verdin CAN_2 */
> + pinctrl_mcu_mcan0: mcu-mcan0-default-pins {
> + pinctrl-single,pins = <
> + AM62X_MCU_IOPAD(0x0038, PIN_INPUT, 0) /* (B3) MCU_MCAN0_RX */ /* SODIMM 26 */
> + AM62X_MCU_IOPAD(0x0034, PIN_OUTPUT, 0) /* (D6) MCU_MCAN0_TX */ /* SODIMM 24 */

This is minor - I realize we already accepted this, but:
/* (B3) MCU_MCAN0_RX */ /* SODIMM 26 */
Vs
/* (B3) MCU_MCAN0_RX - SODIMM 26 */

I wonder if you'd like the second style.


--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D