Re: [PATCH v5 4/6] soc: qcom: Add LLCC support for multi channel DDR

[Komal Bajaj]

On 7/24/2023 6:10 PM, Mukesh Ojha wrote:
> On 7/24/2023 2:11 PM, Komal Bajaj wrote:
> > Add LLCC support for multi channel DDR configuration
> > based on a feature register.
> >
> > Signed-off-by: Komal Bajaj <quic_kbajaj@xxxxxxxxxxx>
> > ---
> >   drivers/soc/qcom/llcc-qcom.c | 26 +++++++++++++++++++++++++-
> >   1 file changed, 25 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> > index 321f8d2079f7..1d2b08dfecea 100644
> > --- a/drivers/soc/qcom/llcc-qcom.c
> > +++ b/drivers/soc/qcom/llcc-qcom.c
> > @@ -12,6 +12,7 @@
> >   #include <linux/kernel.h>
> >   #include <linux/module.h>
> >   #include <linux/mutex.h>
> > +#include <linux/nvmem-consumer.h>
> >   #include <linux/of.h>
> >   #include <linux/of_device.h>
> >   #include <linux/regmap.h>
> > @@ -997,6 +998,19 @@ static int qcom_llcc_cfg_program(struct 
> > platform_device *pdev,
> >       return ret;
> >   }
> >   +static int qcom_llcc_get_cfg_index(struct platform_device *pdev, 
> > u8 *cfg_index)
> > +{
> > +    int ret;
> > +
> > +    ret = nvmem_cell_read_u8(&pdev->dev, "multi-chan-ddr", cfg_index);
> > +    if (ret == -ENOENT || ret == -EOPNOTSUPP) {
> > +        *cfg_index = 0;
> > +        return 0;
> > +    }
> > +
> > +    return ret;
> > +}
> > +
> >   static int qcom_llcc_remove(struct platform_device *pdev)
> >   {
> >       /* Set the global pointer to a error code to avoid referencing 
> > it */
> > @@ -1033,6 +1047,7 @@ static int qcom_llcc_probe(struct 
> > platform_device *pdev)
> >       const struct qcom_llcc_config *cfg;
> >       const struct llcc_slice_config *llcc_cfg;
> >       u32 sz;
> > +    u8 cfg_index;
> >       u32 version;
> >       struct regmap *regmap;
> >   @@ -1050,7 +1065,16 @@ static int qcom_llcc_probe(struct 
> > platform_device *pdev)
> >       }
> >         cfgs = of_device_get_match_data(&pdev->dev);
> > -    cfg = &cfgs->llcc_config[0];
> > +    ret = qcom_llcc_get_cfg_index(pdev, &cfg_index);
> > +     if (ret)
>
> alignment.. ?

Thanks for pointing it out. Will fix it in the next series.

Thanks
Komal

> -Mukesh
>
> > +        goto err;
> > +
> > +    if (cfg_index >= cfgs->num_cfgs) {
> > +        ret = -EINVAL;
> > +        goto err;
> > +    }
> > +
> > +    cfg = &cfgs->llcc_config[cfg_index];
> >         ret = regmap_read(regmap, 
> > cfg->reg_offset[LLCC_COMMON_STATUS0], &num_banks);
> >       if (ret)