Re: [PATCH v2 7/9] drm: atmel-hlcdc: add DPI mode support for XLCDC

[Hari.PrasathGE]

On 12/07/23 8:10 am, Manikandan Muralidharan wrote:
> Add support for Display Pixel Interface (DPI) Compatible Mode
> support in atmel-hlcdc driver for XLCDC IP along with legacy
> pixel mapping.DPI mode BIT is configured in LCDC_CFG5 register.
> 
> Signed-off-by: Manikandan Muralidharan <manikandan.m@xxxxxxxxxxxxx>
> [durai.manickamkr@xxxxxxxxxxxxx: update DPI mode bit using is_xlcdc flag]
> Signed-off-by: Durai Manickam KR <durai.manickamkr@xxxxxxxxxxxxx>
> ---
>   .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c    | 22 ++++++++++++++++---
>   1 file changed, 19 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
> index 27f86cea8bff..c0a1d2d31ed2 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
> @@ -30,10 +30,12 @@
>    *
>    * @base: base CRTC state
>    * @output_mode: RGBXXX output mode
> + * @dpi: output DPI mode
>    */
>   struct atmel_hlcdc_crtc_state {
>   	struct drm_crtc_state base;
>   	unsigned int output_mode;
> +	bool dpi;
>   };
>   
>   static inline struct atmel_hlcdc_crtc_state *
> @@ -138,6 +140,8 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
>   
>   	state = drm_crtc_state_to_atmel_hlcdc_crtc_state(c->state);
>   	cfg = state->output_mode << 8;
> +	if (crtc->dc->desc->is_xlcdc)

save the value in a local variable and use it at all places in the function.

> +		cfg |= state->dpi << 11;
>   
>   	if (!crtc->dc->desc->is_xlcdc && (adj->flags & DRM_MODE_FLAG_NVSYNC))
>   		cfg |= ATMEL_HLCDC_VSPOL;
> @@ -150,7 +154,9 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
>   			   ATMEL_HLCDC_VSPDLYS | ATMEL_HLCDC_VSPDLYE |
>   			   ATMEL_HLCDC_DISPPOL | ATMEL_HLCDC_DISPDLY |
>   			   ATMEL_HLCDC_VSPSU | ATMEL_HLCDC_VSPHO |
> -			   ATMEL_HLCDC_GUARDTIME_MASK | ATMEL_HLCDC_MODE_MASK,
> +			   ATMEL_HLCDC_GUARDTIME_MASK |
> +			   (crtc->dc->desc->is_xlcdc ? ATMEL_XLCDC_MODE_MASK |
> +			   ATMEL_XLCDC_DPI : ATMEL_HLCDC_MODE_MASK),
>   			   cfg);
>   
>   	clk_disable_unprepare(crtc->dc->hlcdc->sys_clk);
> @@ -348,7 +354,15 @@ static int atmel_hlcdc_crtc_select_output_mode(struct drm_crtc_state *state)
>   
>   	hstate = drm_crtc_state_to_atmel_hlcdc_crtc_state(state);
>   	hstate->output_mode = fls(output_fmts) - 1;
> -
> +	if (crtc->dc->desc->is_xlcdc) {
> +		/* check if MIPI DPI bit needs to be set */
> +		if (fls(output_fmts) > 3) {
> +			hstate->output_mode -= 4;
> +			hstate->dpi = true;
> +		} else {
> +			hstate->dpi = false;
> +		}
> +	}
>   	return 0;
>   }
>   
> @@ -452,7 +466,7 @@ static struct drm_crtc_state *
>   atmel_hlcdc_crtc_duplicate_state(struct drm_crtc *crtc)
>   {
>   	struct atmel_hlcdc_crtc_state *state, *cur;
> -
> +	struct atmel_hlcdc_crtc *c = drm_crtc_to_atmel_hlcdc_crtc(crtc);
>   	if (WARN_ON(!crtc->state))
>   		return NULL;
>   
> @@ -463,6 +477,8 @@ atmel_hlcdc_crtc_duplicate_state(struct drm_crtc *crtc)
>   
>   	cur = drm_crtc_state_to_atmel_hlcdc_crtc_state(crtc->state);
>   	state->output_mode = cur->output_mode;
> +	if (c->dc->desc->is_xlcdc)
> +		state->dpi = cur->dpi;
>   
>   	return &state->base;
>   }