Re: [PATCH v1 1/4] arm64: dts: ti: k3-am62x: Enable AUDIO_REFCLKx

From: Francesco Dolcini
Date: Wed Aug 02 2023 - 07:38:25 EST




Il 2 agosto 2023 13:23:50 CEST, Jai Luthra <j-luthra@xxxxxx> ha scritto:
>Hi Francesco,
>
>Thank you for posting this patch.
>
>On Jul 31, 2023 at 16:21:32 +0200, Francesco Dolcini wrote:
>> From: Jai Luthra <j-luthra@xxxxxx>
>>
>> On AM62-based SoCs the AUDIO_REFCLKx clocks can be used as an input to
>> external peripherals when configured through CTRL_MMR, so add the
>> clock nodes.
>>
>> Signed-off-by: Jai Luthra <j-luthra@xxxxxx>
>> Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
>> ---
>> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 18 ++++++++++++++++++
>> arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 18 ++++++++++++++++++
>
>Given currently none of the AM62A boards are using the refclks, can you
>drop those or just mark the nodes as disabled. Whoever is the first user
>can enable them.

I can drop the 2 clocks from AM62A, however, should we really do it? These clocks exist and they are just defined in the DTS, they are not going to be enabled if not used, "ti,am62-epwm-tbclk" is also not disabled for example.

Francesco