RE: [PATCH 1/2] dt-bindings: ARM: at91: Document Microchip SAMA5D29 Curiosity

[Mihai.Sain]

Hi Conor,

Please find bellow my answers.

Hey,

On Tue, Aug 01, 2023 at 02:11:50PM +0300, Mihai Sain wrote:
> From: Andrei Simion <andrei.simion@xxxxxxxxxxxxx>
> 
> Document device tree binding of SAMA5D29 Curiosity, from Microchip.
> 
> Reviewed-by: Mihai Sain <mihai.sain@xxxxxxxxxxxxx>
> Signed-off-by: Andrei Simion <andrei.simion@xxxxxxxxxxxxx>

Your SoB is missing from here.

Sure, I will add my SoB.

> ---
>  Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml 
> b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> index dfb8fd089197..89d75fbb1de4 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> @@ -79,6 +79,13 @@ properties:
>            - const: atmel,sama5d2
>            - const: atmel,sama5
>  
> +      - description: Microchip SAMA5D29 Curiosity
> +        items:
> +          - const: microchip,sama5d29-curiosity
> +          - const: atmel,sama5d29
> +          - const: atmel,sama5d2
> +          - const: atmel,sama5

What is the benefit of adding the two familial compatibles? Is there software that actually uses these?

Thanks,
Conor.

Currently there is no software.
In this file we've just documented the previous boards from sam9, sama5, sama7 MPUs.

Thanks,
Mihai

> +
>        - items:
>            - const: atmel,sama5d27
>            - const: atmel,sama5d2
> --
> 2.41.0
>