Re: [PATCH 5/5] of: Refactor node and property manipulation function locking

[Andy Shevchenko]

On Tue, Aug 01, 2023 at 03:54:48PM -0600, Rob Herring wrote:
> All callers of __of_{add,remove,update}_property() and
> __of_{attach,detach}_node() wrap the call with the devtree_lock
> spinlock. Let's move the spinlock into the functions. This allows moving
> the sysfs update functions into those functions as well.

...

> +out:

out_unlock: ?

> +	raw_spin_unlock_irqrestore(&devtree_lock, flags);
> +	if (!rc)
> +		__of_add_property_sysfs(np, prop);
> +
> +	return rc;

Why not

	if (rc)
		return rc;

	__of_add_property_sysfs(np, prop);
	return 0;

?

...

> +out:
> +	raw_spin_unlock_irqrestore(&devtree_lock, flags);
> +	if (!rc)
> +		__of_remove_property_sysfs(np, prop);
> +	return rc;

As per above.

-- 
With Best Regards,
Andy Shevchenko