Re: [PATCH v1 8/9] PCI: PLDA: starfive: Add JH7110 PCIe controller

From: Bjorn Helgaas
Date: Wed Aug 02 2023 - 13:14:23 EST


On Tue, Aug 01, 2023 at 09:14:53AM +0200, Pali Rohár wrote:
> On Tuesday 01 August 2023 15:05:46 Kevin Xie wrote:
> > On 2023/8/1 7:12, Bjorn Helgaas wrote:
> > ...

> > That's the point, we will add a extra 100ms after PERST# de-assert
> > in the patch-v3 according to Base Spec r6.0 - 6.6.1:
> > msleep(100);
> > gpiod_set_value_cansleep(pcie->reset_gpio, 0);
> >
> > + /* As the requirement in PCIe base spec r6.0, system must wait a
> > + * minimum of 100 ms following exit from a Conventional Reset
> > + * before sending a Configuration Request to the device.*/
> > + msleep(100);
> > +
> > if (starfive_pcie_host_wait_for_link(pcie))
> > return -EIO;
>
> Maybe this information can be useful here:
> https://lore.kernel.org/linux-pci/20211022183808.jdeo7vntnagqkg7g@pali/

Yes, thank you! That is a great summary!