Re: [PATCH 1/1] rust: macros: fix redefine const_name in `vtable`

From: Miguel Ojeda
Date: Wed Aug 02 2023 - 13:40:29 EST


On Mon, Jun 26, 2023 at 9:48 AM Qingsong Chen
<changxian.cqs@xxxxxxxxxxxx> wrote:
>
> If the trait has same function name, the `vtable` macro
> will redefine its `gen_const_name`, e.g.:
> ```rust
> #[vtable]
> pub trait Foo {
> #[cfg(CONFIG_X)]
> fn bar();
>
> #[cfg(not(CONFIG_X))]
> fn bar(x: usize);
> }
> ```
> Use `HashSet` to avoid this.
>
> Signed-off-by: Qingsong Chen <changxian.cqs@xxxxxxxxxxxx>

Applied to `rust-fixes`, thanks! I have reworded it with content from
the cover letter to make it more clear. Please double-check if it is
OK.

By the way, for single-patches, you don't need the cover letter,
especially if both have the same information like here (in fact, in
this case the cover letter was more clear, so it should have been part
of the commit message ideally).

Cheers,
Miguel