Re: [PATCH 1/1] rust: macros: fix redefine const_name in `vtable`

[Gary Guo]

On Wed,  2 Aug 2023 19:50:20 +0000
Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:

> Qingsong Chen <changxian.cqs@xxxxxxxxxxxx> writes:
> >      let mut body_it = body.stream().into_iter();
> > -    let mut functions = Vec::new();
> > +    let mut functions = HashSet::new();
> 
> Please use a `BTreeSet` instead of a `HashSet`. A `HashSet` has
> non-deterministic iteration order, so this will make the macro output
> different things each time you run it.
> 
> Alice
> 

Good point.

Another way is to just use the existing `consts` HashSet to avoid
duplication. Something like

	consts.insert(gen_const_name);

after emitting the const item would probably be sufficient.

Best,
Gary