Re: [PATCH v2] RISC-V: cpu: refactor deprecated strncpy

From: Kees Cook
Date: Wed Aug 02 2023 - 16:36:14 EST


On Wed, Aug 02, 2023 at 12:21:58AM +0000, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
>
> Favor not copying strings onto stack and instead use strings directly.
> This avoids hard-coding sizes and buffer lengths all together.
>
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@xxxxxxxxxxxxxxx
> Suggested-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Signed-off-by: Justin Stitt <justinstitt@xxxxxxxxxx>

I like it! ;)

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook