Re: [PATCH 1/3] dt-bindings: arm: qcom: add sc7180-lazor board bindings

[Doug Anderson]

Hi,

On Wed, Aug 2, 2023 at 2:58 AM Sheng-Liang Pan
<sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> Introduce more sc7180-lazor sku and board version configuration,
> add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen,
> add new board version 10 for audio codec ALC5682i-VS.
>
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>
>  .../devicetree/bindings/arm/qcom.yaml         | 43 ++++++++++++++++---
>  1 file changed, 38 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 450f616774e0..e0efc80a72e1 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -460,7 +460,7 @@ properties:
>            - const: google,lazor-rev2
>            - const: qcom,sc7180
>
> -      - description: Acer Chromebook Spin 513 (rev3 - 8)
> +      - description: Acer Chromebook Spin 513 (rev3 - 9)
>          items:
>            - const: google,lazor-rev3
>            - const: google,lazor-rev4
> @@ -468,6 +468,7 @@ properties:
>            - const: google,lazor-rev6
>            - const: google,lazor-rev7
>            - const: google,lazor-rev8
> +          - const: google,lazor-rev9

I don't think this is correct. lazor-rev9 has the Parade bridge chip,
not the TI bridge chip. It can't be lumped together with the earlier
revisions. What you want to do is leave the "rev3 - 8" alone, then add
a new entry just for "-rev9". Your brand new revision 10 doesn't need
its own entry in this list because it's the "newest rev".



> @@ -550,6 +565,24 @@ properties:
>            - const: google,lazor-sku6
>            - const: qcom,sc7180
>
> +      - description: Acer Chromebook 511 no-esim (rev9)
> +        items:
> +          - const: google,lazor-rev9-sku15
> +          - const: qcom,sc7180
> +
> +      - description: Acer Chromebook 511 no-esim(newest rev)

nit: please put a space before "(newest rev)"


> +        items:
> +          - const: google,lazor-sku15

You're missing the second item: "const: qcom,sc7180"


> +      - description: Acer Chromebook 511 without Touchscreen no-esim (rev9)
> +        items:
> +          - const: google,lazor-rev9-sku18
> +          - const: qcom,sc7180
> +
> +      - description: Acer Chromebook 511 without Touchscreen no-esim(newest rev)

nit: please put a space before "(newest rev)"


> +        items:
> +          - const: google,lazor-sku18

You're missing the second item: "const: qcom,sc7180"