Re: [PATCH 1/2 v11] dt-bindings: watchdog: marvell GTI system watchdog driver

[Guenter Roeck]

On 8/2/23 20:25, Bharat Bhushan wrote:
> Add binding documentation for the Marvell GTI system
> watchdog driver.
>
> Signed-off-by: Bharat Bhushan <bbhushan2@xxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
> v11:
>   - No change
>
> v10:
>   - Added Reviewed by Krzysztof Kozlowski
>
> v9:
>   - Rename binding file name from marvell,octeontx2-wdt.yaml to
>     marvell,cn10624-wdt.yaml
>   - "allOf: - $ref: watchdog.yaml#" moved after maintainers
>   - clocks have maxItems rather than minItems
>   - Added "clock-names" name defination
>   - Added Fallback to compatible
>
> v8:
>    - Compatible name as per soc name
>
>   .../watchdog/marvell,cn10624-wdt.yaml         | 83 +++++++++++++++++++
>   .../watchdog/marvell,cn10624-wdt.yaml         | 83 +++++++++++++++++++
>   1 file changed, 83 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/watchdog/marvell,cn10624-wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/marvell,cn10624-wdt.yaml b/Documentation/devicetree/bindings/watchdog/marvell,cn10624-wdt.yaml
> new file mode 100644
> index 000000000000..1b583f232e53
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/marvell,cn10624-wdt.yaml
> @@ -0,0 +1,83 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/marvell,cn10624-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Global Timer (GTI) system watchdog
> +
> +maintainers:
> +  - Bharat Bhushan <bbhushan2@xxxxxxxxxxx>
> +
> +allOf:
> +  - $ref: watchdog.yaml#
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +          - marvell,cn9670-wdt
> +          - marvell,cn10624-wdt
> +
> +      - items:
> +          - enum:
> +              - marvell,cn9880-wdt
> +              - marvell,cnf9535-wdt
> +          - const: marvell,cn9670-wdt
> +
> +      - items:
> +          - enum:
> +              - marvell,cn10308-wdt
> +              - marvell,cnf10518-wdt
> +          - const: marvell,cn10624-wdt
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    items:
> +      - const: refclk
> +
> +  marvell,wdt-timer-index:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 63
> +    description:
> +      An SoC have many timers (up to 64), firmware can reserve one or more timer
> +      for some other use case and configures one of the global timer as watchdog
> +      timer. Firmware will update this field with the timer number configured
> +      as watchdog timer.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        watchdog@802000040000 {
> +            compatible = "marvell,cn9670-wdt";
> +            reg = <0x00008020 0x00040000 0x00000000 0x00020000>;
> +            interrupts = <GIC_SPI 38 IRQ_TYPE_EDGE_RISING>;
> +            clocks = <&sclk>;
> +            clock-names = "refclk";
> +            marvell,wdt-timer-index = <63>;
> +        };
> +    };
> +
> +...