Re: [PATCH v8 2/2] PCI/ACPI: Use device constraints instead of dates to opt devices into D3
From: kernel test robot
Date: Thu Aug 03 2023 - 01:05:04 EST
Hi Mario,
kernel test robot noticed the following build errors:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on pci/next pci/for-linus westeri-thunderbolt/next linus/master v6.5-rc4 next-20230802]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/ACPI-Add-comments-to-clarify-some-ifdef-statements/20230803-041214
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20230802201013.910-3-mario.limonciello%40amd.com
patch subject: [PATCH v8 2/2] PCI/ACPI: Use device constraints instead of dates to opt devices into D3
config: i386-randconfig-i005-20230731 (https://download.01.org/0day-ci/archive/20230803/202308031243.Mmwm1IHI-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230803/202308031243.Mmwm1IHI-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308031243.Mmwm1IHI-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
ld: drivers/pci/pci-acpi.o: in function `acpi_pci_device_constraint_d3':
>> drivers/pci/pci-acpi.c:1055: undefined reference to `acpi_get_lps0_constraint'
vim +1055 drivers/pci/pci-acpi.c
1045
1046 /*
1047 * acpi_pci_device_constraint_d3 - determine if device constraints require D3
1048 * @dev: PCI device to check
1049 *
1050 * Returns true if the PEP constraints for the device is enabled and
1051 * requires D3.
1052 */
1053 bool acpi_pci_device_constraint_d3(struct pci_dev *dev)
1054 {
> 1055 int constraint = acpi_get_lps0_constraint(&dev->dev);
1056
1057 if (constraint < 0) {
1058 pci_dbg(dev, "ACPI device constraint not present\n");
1059 return false;
1060 }
1061
1062 return constraint >= 3;
1063 }
1064
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki