Re: [PATCH V2 2/2] dt-bindings: cpufreq: Convert ti-cpufreq to json schema

From: Dhruva Gole
Date: Thu Aug 03 2023 - 02:01:56 EST


On Aug 01, 2023 at 18:33:41 -0500, Nishanth Menon wrote:
> Move the ti-cpufreq binding over to opp and convert convert the free

Minor nitpik, maybe can be fixed while applying the patch. Checkpatch caught this,
Possible repeated word: 'convert'

> text binding to json-schema.
>
> Signed-off-by: Nishanth Menon <nm@xxxxxx>
> ---

Otherwise, LGTM

Reviewed-by: Dhruva Gole <d-gole@xxxxxx>

> Changes since V1:
> - Fixup $subject of the patch to indicate json schema rather than yaml.
> - Change filename to matchup with binding compatible
> - Dropped un-used labels
> - Dropped "|" in "description"
>
> V1: https://lore.kernel.org/all/20230724153911.1376830-6-nm@xxxxxx/
>
> Side note: cleanups in dt is picked up on Tony's tree:
> https://lore.kernel.org/all/20230731062551.GH5194@xxxxxxxxxxx/
>
> .../bindings/cpufreq/ti-cpufreq.txt | 132 ------------------
> .../opp/operating-points-v2-ti-cpu.yaml | 88 ++++++++++++
> 2 files changed, 88 insertions(+), 132 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt
> create mode 100644 Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt b/Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt
> deleted file mode 100644
[..snip..]

--
Best regards,
Dhruva Gole <d-gole@xxxxxx>