Re: [PATCH v2 1/1] serial: core: Fix serial_base_match() after fixing controller port name

[Jiri Slaby]

On 03. 08. 23, 9:10, Tony Lindgren wrote:
> While fixing DEVNAME to be more usable, I broke serial_base_match() as the
> ctrl and port prefix for device names seemed unnecessary.
>
> The prefixes are still needed by serial_base_match() to probe the serial
> base controller port, and serial tx is now broken.
>
> Let's fix the issue by checking against dev->type and drv->name instead
> of the prefixes that are no longer in the DEVNAME.
>
> Fixes: 1ef2c2df1199 ("serial: core: Fix serial core controller port name to show controller id")
> Reported-by: kernel test robot <oliver.sang@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-lkp/202308021529.35b3ad6c-oliver.sang@xxxxxxxxx
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>

A lot better:

Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>


--
js
suse labs