Re: [PATCH v1] parisc: pci-dma: remove unused and dead EISA code and comment

From: Helge Deller
Date: Thu Aug 03 2023 - 04:14:47 EST


On 8/2/23 18:33, Petr Tesarik wrote:
From: Petr Tesarik <petr.tesarik.ext@xxxxxxxxxx>

Clearly, this code isn't needed, but it gives a false positive when
grepping the complete source tree for coherent_dma_mask.

Signed-off-by: Petr Tesarik <petr.tesarik.ext@xxxxxxxxxx>

queued up in parisc git tree.

Thanks!
Helge

---
arch/parisc/kernel/pci-dma.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c
index d818ece23b4a..3f6b507970eb 100644
--- a/arch/parisc/kernel/pci-dma.c
+++ b/arch/parisc/kernel/pci-dma.c
@@ -417,14 +417,6 @@ void *arch_dma_alloc(struct device *dev, size_t size,
map_uncached_pages(vaddr, size, paddr);
*dma_handle = (dma_addr_t) paddr;

-#if 0
-/* This probably isn't needed to support EISA cards.
-** ISA cards will certainly only support 24-bit DMA addressing.
-** Not clear if we can, want, or need to support ISA.
-*/
- if (!dev || *dev->coherent_dma_mask < 0xffffffff)
- gfp |= GFP_DMA;
-#endif
return (void *)vaddr;
}