Re: [PATCH v3 1/8] thermal: core: Add mechanism for connecting trips with driver data

From: Daniel Lezcano
Date: Thu Aug 03 2023 - 09:19:53 EST


On 02/08/2023 18:48, Rafael J. Wysocki wrote:

[ ... ]

Let me check if I can do something on top of your series to move it in
the ACPI driver.

It doesn't need to be on top of my series, so if you have an idea,
please just let me know what it is.

It can't be entirely in the ACPI driver AFAICS, though, because
trips[i] need to be modified on updates and they belong to the core.
Hence, the driver needs some help from the core to get to them. It
can be something like "this is my trip tag and please give me the
address of the trip matching it" or similar, but it is needed, because
the driver has to assume that the trip indices used by it initially
may change.

May be I'm missing something but driver_ref does not seems to be used except when assigning it, no?

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog