Re: [PATCH] gpio: timberdale: remove unneeded call to platform_set_drvdata()

[Bartosz Golaszewski]

On Tue, Aug 1, 2023 at 9:32 AM Andrei Coardos <aboutphysycs@xxxxxxxxx> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@xxxxxxxxxxx>
> Signed-off-by: Andrei Coardos <aboutphysycs@xxxxxxxxx>
> ---
>  drivers/gpio/gpio-timberdale.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-timberdale.c b/drivers/gpio/gpio-timberdale.c
> index de14949a3fe5..bbd9e9191199 100644
> --- a/drivers/gpio/gpio-timberdale.c
> +++ b/drivers/gpio/gpio-timberdale.c
> @@ -256,8 +256,6 @@ static int timbgpio_probe(struct platform_device *pdev)
>         if (err)
>                 return err;
>
> -       platform_set_drvdata(pdev, tgpio);
> -
>         /* make sure to disable interrupts */
>         iowrite32(0x0, tgpio->membase + TGPIO_IER);
>
> --
> 2.34.1
>

Applied, thanks!

Bart