Re: [PATCH] MAINTAINERS: Update TTY layer for lists and recently added files

From: Ilpo Järvinen
Date: Thu Aug 03 2023 - 10:12:36 EST


On Wed, 2 Aug 2023, Tony Lindgren wrote:

> * Jiri Slaby <jirislaby@xxxxxxxxxx> [230726 10:12]:
> > On 25. 07. 23, 19:29, Greg Kroah-Hartman wrote:
> > > On Tue, Jul 25, 2023 at 07:28:46PM +0200, Greg Kroah-Hartman wrote:
> > > > On Mon, Jul 24, 2023 at 07:53:27AM +0300, Tony Lindgren wrote:
> > > > > * Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> [230721 10:19]:
> > > > > > On Fri, Jul 21, 2023 at 10:23:32AM +0300, Tony Lindgren wrote:
> > > > > > > Add mailing lists for linux-serial and lkml for the TTY layer. And let's
> > > > > > > list the recently added files. This makes it easier for get_maintainer.pl
> > > > > > > to include linux-serial for patches.
> > > > > >
> > > > > > Shouldn't serial_* stuff go to the "SERIAL DRIVERS" section?
> > > > >
> > > > > Not sure if there's some reason we have "TTY LAYER" with serial_core
> > > > > files. If not, yeah let's move the serial files.
> > > >
> > > > I'll take this patch, can you send a new one that removes the serial
> > > > files from this entry as I don't think they are needed in here anymore.
> > >
> > > Better yet, they should be merged probably. Although I don't know if
> > > Jiri wants to be responsible for serial stuff, that's his call...
> >
> > No problem. I actually didn't realize they are separate. So feel free to
> > submit a patch, so we have a single MAINTAINTERS file entry...
>
> How about something like this?
>
> Tony
>
> 8< ----------------------
> diff --git a/MAINTAINERS b/MAINTAINERS
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19319,13 +19319,6 @@ F: Documentation/devicetree/bindings/serial/serial.yaml
> F: drivers/tty/serdev/
> F: include/linux/serdev.h
>
> -SERIAL DRIVERS
> -M: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> -L: linux-serial@xxxxxxxxxxxxxxx
> -S: Maintained
> -F: Documentation/devicetree/bindings/serial/
> -F: drivers/tty/serial/
> -
> SERIAL IR RECEIVER
> M: Sean Young <sean@xxxxxxxx>
> L: linux-media@xxxxxxxxxxxxxxx
> @@ -21760,20 +21753,16 @@ W: https://github.com/srcres258/linux-doc
> T: git git://github.com/srcres258/linux-doc.git doc-zh-tw
> F: Documentation/translations/zh_TW/
>
> -TTY LAYER
> +TTY LAYER AND SERIAL DRIVERS
> M: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> M: Jiri Slaby <jirislaby@xxxxxxxxxx>
> L: linux-kernel@xxxxxxxxxxxxxxx
> L: linux-serial@xxxxxxxxxxxxxxx
> S: Supported
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> +F: Documentation/devicetree/bindings/serial/
> F: Documentation/driver-api/serial/
> F: drivers/tty/
> -F: drivers/tty/serial/serial_base.h
> -F: drivers/tty/serial/serial_base_bus.c
> -F: drivers/tty/serial/serial_core.c
> -F: drivers/tty/serial/serial_ctrl.c
> -F: drivers/tty/serial/serial_port.c
> F: include/linux/selection.h
> F: include/linux/serial.h
> F: include/linux/serial_core.h

The separation of these two has always felt a bit artificial to me.

Acked-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

--
i.