Re: Regression apparently caused by commit 088a40980efbc2c449b72f0f2c7ebd82f71d08e2 "ASoC: amd: acp: add pm ops support for acp pci driver"

From: Mark Brown
Date: Thu Aug 03 2023 - 15:43:07 EST


On Thu, Aug 03, 2023 at 10:22:07PM +0300, Marian Postevca wrote:

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns. Doing this makes your messages much
easier to read and reply to.

> I'm no expert in runtime power management (though I did read a bit on
> it), so I don't understand all the things that happen underneath, but
> one thing that is not clear to me is who's supposed to mark activity
> on this device and keep it from entering autosuspend if the user wants
> to play some sound? Shouldn't there be some counterpart that calls
> pm_runtime_mark_last_busy() ? I looked through the code and can't
> find who's calling pm_runtime_mark_last_busy().

The core will hold devices out of suspend through a combination of DAPM
and PCMs being held open, it just does get and puts rather than making
an effort to use autosuspend delays. See the calls to
pm_runtime_get_sync() in the core.

Attachment: signature.asc
Description: PGP signature