Re: [PATCH] x86/paravirt: Fix tlb_remove_table function callback prototype warning

From: Kees Cook
Date: Thu Aug 03 2023 - 18:43:06 EST


On Wed, 26 Jul 2023 16:11:43 -0700, Kees Cook wrote:
> Under W=1, this warning is visible in Clang 16 and newer:
>
> arch/x86/kernel/paravirt.c:337:4: warning: cast from 'void (*)(struct mmu_gather *, struct page *)' to 'void (*)(struct mmu_gather *, void *)' converts to incompatible function type [-Wcast-function-type-strict]
> (void (*)(struct mmu_gather *, void *))tlb_remove_page,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Add a direct wrapper instead, which will make this warning (and
> potential KCFI failures) go away.
>
> [...]

Applied to for-next/hardening, thanks!

[1/1] x86/paravirt: Fix tlb_remove_table function callback prototype warning
https://git.kernel.org/kees/c/fcce1c6cb156

Take care,

--
Kees Cook