Re: [PATCH v2 01/12] iommu: Move iommu fault data to linux/iommu.h

[Baolu Lu]

On 2023/8/3 15:53, Tian, Kevin wrote:
> > From: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> > Sent: Thursday, July 27, 2023 1:48 PM
> >
> > The iommu fault data is currently defined in uapi/linux/iommu.h, but is
> > only used inside the iommu subsystem. Move it to linux/iommu.h, where it
> > will be more accessible to kernel drivers.
> >
> > With this done, uapi/linux/iommu.h becomes empty and can be removed
> > from
> > the tree.
> >
> > Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> > ---
> >   include/linux/iommu.h      | 152 +++++++++++++++++++++++++++++++++-
> >   include/uapi/linux/iommu.h | 161 -------------------------------------
> >   MAINTAINERS                |   1 -
> >   3 files changed, 151 insertions(+), 163 deletions(-)
> >   delete mode 100644 include/uapi/linux/iommu.h
>
> put this behind patch2/3 then there are less lines to be moved.

My idea was that "include/uapi/linux.h" is not used anywhere and we no
longer want to maintain it. Hence, we should remove it before changing
any lines inside it.

Best regards,
baolu