Re: [PATCH v1 1/1] math.h: Document abs_diff()

From: Andy Shevchenko
Date: Fri Aug 04 2023 - 01:36:59 EST


On Thu, Aug 03, 2023 at 10:23:48PM -0700, Randy Dunlap wrote:
> On 8/3/23 22:09, Andy Shevchenko wrote:

...

> > +/**
> > + * abs_diff - return absolute value of the difference between the arguments
> > + * @a: the first argument
> > + * @b: the second argument
> > + *
> > + * @a and @b has to be of the same type. With this restriction we compare

> Preferably s/has/have/.

Thank you! I fixed it locally, I hope Andrew can update this, but if needed
I will send a v2 with the proposed correction.

> > + * signed to signed and unsigned to unsigned. The result is the subtraction
> > + * the smaller of the two from the bigger, hence result is always a positive
> > + * value.
> > + *
> > + * Return: an absolute value of the difference between the @a and @b.
> > + */

--
With Best Regards,
Andy Shevchenko