Re: [PATCH] kthread: unexport __kthread_should_park()

From: Kees Cook
Date: Fri Aug 04 2023 - 04:39:31 EST


On Fri, Aug 04, 2023 at 08:41:51AM +0200, Greg Kroah-Hartman wrote:
> There are no in-kernel users of __kthread_should_park() so mark it as
> static and do not export it.
>
> Cc: John Stultz <jstultz@xxxxxxxxxx>
> Cc: "Peter Zijlstra (Intel)" <peterz@xxxxxxxxxxxxx>
> Cc: "Arve Hjønnevåg" <arve@xxxxxxxxxxx>
> Cc: Valentin Schneider <vschneid@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: "Christian Brauner (Microsoft)" <brauner@xxxxxxxxxx>
> Cc: Mike Christie <michael.christie@xxxxxxxxxx>
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Cc: Nicholas Piggin <npiggin@xxxxxxxxx>
> Cc: Zqiang <qiang1.zhang@xxxxxxxxx>
> Cc: Prathu Baronia <quic_pbaronia@xxxxxxxxxxx>
> Cc: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Yeah. Seems like it got an EXPORT because it was duplicating the
neighboring functions?

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook