RE: [PATCH 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board

From: Delphine_CC_Chiu/WYHQ/Wiwynn
Date: Fri Aug 04 2023 - 06:07:16 EST




> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Thursday, August 3, 2023 7:14 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@xxxxxxxxxx>;
> patrick@xxxxxxxxx; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
> Joel Stanley <joel@xxxxxxxxx>; Andrew Jeffery <andrew@xxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-aspeed@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite
> V4 board
>
> Security Reminder: Please be aware that this email is sent by an external
> sender.
>
> On 02/08/2023 04:34, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> >> Sent: Thursday, July 27, 2023 2:49 PM
> >> To: Delphine_CC_Chiu/WYHQ/Wiwynn
> <Delphine_CC_Chiu@xxxxxxxxxx>;
> >> patrick@xxxxxxxxx; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof
> >> Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley
> >> <conor+dt@xxxxxxxxxx>; Joel Stanley <joel@xxxxxxxxx>; Andrew Jeffery
> >> <andrew@xxxxxxxx>
> >> Cc: devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> >> linux-aspeed@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> >> Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: add Facebook
> >> Yosemite V4 board
> >>
> >> Security Reminder: Please be aware that this email is sent by an
> >> external sender.
> >>
> >> On 27/07/2023 05:39, Delphine CC Chiu wrote:
> >>> Document the new compatibles used on Facebook Yosemite V4.
> >>>
> >>> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx>
> >>> ---
> >>> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>
> >> I got the same patch four times...
> > It was my oversight to send the same patch multiple times.
> > Would you please to tell that should I resend a new version, or these
> patches has been already under reviewed.
> > Thank you.
>
> I don't see versioning, no changelog. Thus if you send the same patches all
> the time, then answer is - please version your patches, implement the
> feedback and explain in changelog what changed.
It seems that versioning didn't added successfully in duplicated patches.

I will update v5 patches for versioning, changelogs and all feedback's implementation, without duplicating sending.
Please help to tell if there's any feedback I lost, thank you.
>
> Otherwise it will not get reviewed, so I assume this was not reviewed and it
> is waiting for proper submission.
>
> Best regards,
> Krzysztof