Re: [PATCH v2] staging: vme_user: fix check alignment should match open parenthesis

[Alexon Oliveira]

On Fri, Aug 04, 2023 at 05:11:29PM +0300, Dan Carpenter wrote:
> On Fri, Aug 04, 2023 at 11:07:36AM -0300, Alexon Oliveira wrote:
> > On Fri, Aug 04, 2023 at 03:23:17PM +0200, Greg KH wrote:
> > > On Tue, Aug 01, 2023 at 01:17:07PM -0300, Alexon Oliveira wrote:
> > > > First patch was intended to fix all "CHECK: Alignment should match open parenthesis",
> > > > but added new warnings in the process. This patch is intended to fixed them all,
> > > > on lines 133, 142, 144, 145 and 173.
> > > 
> > > Patches are stand-alone, we have no idea what "First patch" is.
> > >
> > 
> > That was just me being verbose and given more details related to the
> > v1 of this patch. I apologize. Nevermind that. What is worth is below
> > the ---
> > 
> > > Please look at the commit log for this file, or for all of
> > > drivers/staging:
> > > 	git log drivers/staging/
> > > and get an idea of what changelog text should look like.
> > > 
> > 
> > ACK. So the correct changelog should be:
> > 
> > staging: vme_user: fix check alignment should match open parenthesis
> > 
> > Fixed the following as reported by checkpatch to adhere to the
> > Linux kernel coding-style guidelines.
> > 
> > Changes in v2:
> > - Fixed CHECK: line length exceeds 100 columns, noted by Greg KH and Dan Carpenter
> > - Fixed CHECK: Alignment should match open parenthesis
> > - Fixed CHECK: Lines should not end with a '('
> 
> This v2 changelogs go under the --- cut off line under the Signed-off-by
> section.
> 
> > 
> > Changes in v1:
> > - Fixed CHECK: Alignment should match open parenthesis
> 
> No one is going to NAK your patch for saying this but to talk about
> changes in v1 doesn't make sense.
> 
> The new patch will be v3.
> 

ACK. Thank you for the heads up. Writing the v3 now.

> regards,
> dan carpenter
> 

Thank you.

Alexon Oliveira