Re: [PATCH] floppy: ERROR: that open brace { should be on the previous line

[Christophe Leroy]

Hello,

Le 20/07/2023 à 12:17, zhangyongle001@xxxxxxxxxx a écrit :
> [Vous ne recevez pas souvent de courriers de zhangyongle001@xxxxxxxxxx. 
> D?couvrez pourquoi ceci est important ? 
> https://aka.ms/LearnAboutSenderIdentification ]
> 
> Fix twoce occurrences of the checkpatch.pl error:
> ERROR: that open brace { should be on the previous line


Can you please explain the purpose of those changes ? Do you use some 
tools that get disturbed by such cosmetic errors ? Otherwise what is 
your reason ?

We don't accept such standelone minor cosmetic changes at the first 
place because it looks like a waste of time.

If you have major reasons to want those changes, please re-submit with a 
details explanation in the commit message.

Thanks
Christophe



> 
> Signed-off-by: zhangyongle <zhangyongle001@xxxxxxxxxx>
> ---
>   arch/powerpc/include/asm/floppy.h | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/powerpc/include/asm/floppy.h
> b/arch/powerpc/include/asm/floppy.h
> index f8ce178b43b7..1ae67d2629be 100644
> --- a/arch/powerpc/include/asm/floppy.h
> +++ b/arch/powerpc/include/asm/floppy.h
> @@ -163,16 +163,14 @@ static int hard_dma_setup(char *addr, unsigned
> long size, int mode, int io)
>         return 0;
>   }
> 
> -static struct fd_dma_ops real_dma_ops =
> -{
> +static struct fd_dma_ops real_dma_ops = {
>         ._disable_dma = disable_dma,
>         ._free_dma = free_dma,
>         ._get_dma_residue = get_dma_residue,
>         ._dma_setup = hard_dma_setup
>   };
> 
> -static struct fd_dma_ops virt_dma_ops =
> -{
> +static struct fd_dma_ops virt_dma_ops = {
>         ._disable_dma = vdma_disable_dma,
>         ._free_dma = vdma_nop,
>         ._get_dma_residue = vdma_get_dma_residue,
> -- 
> 2.40.1
>