Re: [PATCH v7 5/7] nvmem: core: Rework layouts to become platform devices

[Miquel Raynal]

Hi Dan,

dan.carpenter@xxxxxxxxxx wrote on Fri, 4 Aug 2023 19:05:20 +0300:

> On Fri, Aug 04, 2023 at 05:46:25PM +0200, Miquel Raynal wrote:
> > Actually of_nvmem_layout_get_container() already returns NULL if
> > CONFIG_OF is not defined. This helper returns either a valid pointer of
> > NULL. Where can it return an error pointer?  
> 
> This is from linux-next.

Ah! Ok I missed that one, we don't need this double implementation, as
of_nvmem_layout_get_container just calls a function that already has a
static inline counterpart in the of.h header, which returns NULL. I'll
make the change, thanks for the pointer.

> 
> include/linux/nvmem-consumer.h
>    256  static inline struct device_node *
>    257  of_nvmem_layout_get_container(struct nvmem_device *nvmem)
>    258  {
>    259          return ERR_PTR(-EOPNOTSUPP);
>    260  }
>    261  #endif /* CONFIG_NVMEM && CONFIG_OF */
> 
> regards,
> dan carpenter


Thanks,
Miquèl