Re: [PATCH net-next 0/3] virtchnl: fix fake 1-elem arrays

From: Tony Nguyen
Date: Fri Aug 04 2023 - 14:08:24 EST


On 8/4/2023 9:38 AM, Alexander Lobakin wrote:
From: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>
Date: Fri, 28 Jul 2023 17:52:04 +0200

6.5-rc1 started spitting warning splats when composing virtchnl
messages, precisely on virtchnl_rss_key and virtchnl_lut:

[ 84.167709] memcpy: detected field-spanning write (size 52) of single
field "vrk->key" at drivers/net/ethernet/intel/iavf/iavf_virtchnl.c:1095
(size 1)
[ 84.169915] WARNING: CPU: 3 PID: 11 at drivers/net/ethernet/intel/
iavf/iavf_virtchnl.c:1095 iavf_set_rss_key+0x123/0x140 [iavf]

[...]

.../ethernet/intel/i40e/i40e_virtchnl_pf.c | 9 +-
drivers/net/ethernet/intel/iavf/iavf.h | 6 +-
drivers/net/ethernet/intel/iavf/iavf_client.c | 4 +-
drivers/net/ethernet/intel/iavf/iavf_client.h | 2 +-
.../net/ethernet/intel/iavf/iavf_virtchnl.c | 75 +++++------
drivers/net/ethernet/intel/ice/ice_virtchnl.c | 2 +-
include/linux/avf/virtchnl.h | 127 +++++++++++-------
7 files changed, 124 insertions(+), 101 deletions(-)


Tony, could you please take it via your next tree? I'd like the
validation to make sure more different host <-> guest pairs work.

(with Kees' tags, assuming he reviewed and approved the whole series, I
asked about #2 already)

Thanks,
Olek

Ok, will apply it today. For the future if you want it through IWL, can you tag it with the iwl-* target (and have IWL in the To)? Since this had 'net-next' and was 'To' netdev maintainers, I took it that you wanted it taken through netdev.

Thanks,
Tony