Re: [PATCH v14 14/25] gunyah: rsc_mgr: Add platform ops on mem_lend/mem_reclaim

[Bjorn Andersson]

On Tue, Jun 13, 2023 at 10:20:42AM -0700, Elliot Berman wrote:
> On Qualcomm platforms, there is a firmware entity which controls access
> to physical pages. In order to share memory with another VM, this entity
> needs to be informed that the guest VM should have access to the memory.
> 

Why isn't this handled by the system above us?

> Reviewed-by: Alex Elder <elder@xxxxxxxxxx>
> Co-developed-by: Prakruthi Deepak Heragu <quic_pheragu@xxxxxxxxxxx>
> Signed-off-by: Prakruthi Deepak Heragu <quic_pheragu@xxxxxxxxxxx>
> Signed-off-by: Elliot Berman <quic_eberman@xxxxxxxxxxx>
> ---
>  drivers/virt/gunyah/Kconfig                 |  4 ++
>  drivers/virt/gunyah/Makefile                |  2 +
>  drivers/virt/gunyah/gunyah_platform_hooks.c | 80 +++++++++++++++++++++
>  drivers/virt/gunyah/rsc_mgr.h               |  3 +
>  drivers/virt/gunyah/rsc_mgr_rpc.c           | 18 ++++-
>  include/linux/gunyah_rsc_mgr.h              | 17 +++++
>  6 files changed, 122 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/virt/gunyah/gunyah_platform_hooks.c
> 
> diff --git a/drivers/virt/gunyah/Kconfig b/drivers/virt/gunyah/Kconfig
> index 1a737694c333d..de815189dab6c 100644
> --- a/drivers/virt/gunyah/Kconfig
> +++ b/drivers/virt/gunyah/Kconfig
> @@ -4,6 +4,7 @@ config GUNYAH
>  	tristate "Gunyah Virtualization drivers"
>  	depends on ARM64
>  	depends on MAILBOX
> +	select GUNYAH_PLATFORM_HOOKS
>  	help
>  	  The Gunyah drivers are the helper interfaces that run in a guest VM
>  	  such as basic inter-VM IPC and signaling mechanisms, and higher level
> @@ -11,3 +12,6 @@ config GUNYAH
>  
>  	  Say Y/M here to enable the drivers needed to interact in a Gunyah
>  	  virtual environment.
> +
> +config GUNYAH_PLATFORM_HOOKS

Automatically selected by GUNYAH and the only platform so far, no need
to keep this as a separate Kconfig.

> +	tristate
> diff --git a/drivers/virt/gunyah/Makefile b/drivers/virt/gunyah/Makefile
> index bacf78b8fa337..4fbeee521d60a 100644
> --- a/drivers/virt/gunyah/Makefile
> +++ b/drivers/virt/gunyah/Makefile
> @@ -1,4 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0
>  
> +obj-$(CONFIG_GUNYAH_PLATFORM_HOOKS) += gunyah_platform_hooks.o
> +

Why is this added before the core gunyah components?

>  gunyah-y += rsc_mgr.o rsc_mgr_rpc.o vm_mgr.o vm_mgr_mm.o
>  obj-$(CONFIG_GUNYAH) += gunyah.o

Regards,
Bjorn