Re: [PATCH v3 1/2] dt-bindings: hwmon: Add MAX6639
From: Krzysztof Kozlowski
Date: Sat Aug 05 2023 - 16:25:09 EST
On 03/08/2023 16:43, Naresh Solanki wrote:
> From: Marcello Sylvester Bauer <sylv@xxxxxxx>
>
> Add binding documentation for Maxim MAX6639 fan-speed controller.
>
> Signed-off-by: Marcello Sylvester Bauer <sylv@xxxxxxx>
> Signed-off-by: Naresh Solanki <Naresh.Solanki@xxxxxxxxxxxxx>
> ---
...
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fan-controller@10 {
> + compatible = "maxim,max6639";
> + reg = <0x10>;
I wished the examples were a bit more complete (not only 40% of your
properties). Well, that's not a stopper, so:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Best regards,
Krzysztof