Re: [PATCH v3 3/8] dt-bindings: clock: Add Marvell PXA1908 clock bindings

From: Krzysztof Kozlowski
Date: Sat Aug 05 2023 - 16:52:36 EST


On 04/08/2023 15:32, Duje Mihanović wrote:
> Add dt bindings and documentation for the Marvell PXA1908 clock
> controller.
>
> Signed-off-by: Duje Mihanović <duje.mihanovic@xxxxxxxx>


> +++ b/Documentation/devicetree/bindings/clock/marvell,pxa1908.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2

...

> +examples:
> + # APMU block:
> + - |
> + clock-controller@d4282800 {
> + compatible = "marvell,pxa1908-apmu";
> + reg = <0xd4282800 0x400>;
> + #clock-cells = <1>;
> + };
> diff --git a/include/dt-bindings/clock/marvell,pxa1908.h b/include/dt-bindings/clock/marvell,pxa1908.h
> new file mode 100644
> index 000000000000..1fff3bcefd21
> --- /dev/null
> +++ b/include/dt-bindings/clock/marvell,pxa1908.h
> @@ -0,0 +1,92 @@
> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-3-Clause */

Any particular reason to use different BSD-3 than bindings? Not easy to
spot this difference...

Best regards,
Krzysztof