RE: [PATCH] i2c: tegra: Fix the check during DMA channel release

From: Akhil R
Date: Sun Aug 06 2023 - 10:26:41 EST


> Hi Thierry and Akhil,
>
> On Mon, Jul 17, 2023 at 05:24:15PM +0200, Thierry Reding wrote:
> > On Mon, Jul 17, 2023 at 08:42:40PM +0530, Akhil R wrote:
> > > Check for error and NULL before attempting to release DMA channel.
> > >
> > > This, otherwise, was causing panic and crash in kernel when the
> > > dma_chan has an invalid value. The condition occurs during
> > > init_dma() when the dma_request_chan() function returns an error.
> > >
> > > Fixes: fcc8a89a1c83 ("i2c: tegra: Share same DMA channel for RX and
> > > TX")
> > > Signed-off-by: Akhil R <akhilrajeev@xxxxxxxxxx>
> > > ---
> > > drivers/i2c/busses/i2c-tegra.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I guess this patch is not needed anymore.
Correct. This can be discarded.

The below patch from Thierry is for the same fix.
https://lore.kernel.org/linux-i2c/20230707132619.2998382-1-thierry.reding@xxxxxxxxx/

Regards,
Akhil