Re: [PATCH v2 3/3] arm64: dts: qcom: sc7180: Add board id for lazor/limozeen

[Krzysztof Kozlowski]

On 04/08/2023 11:58, Sheng-Liang Pan wrote:
> add BRD_ID(0, Z, 0) = 10 for new board with ALC5682i-VS
> 
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
> 
> Changes in v2:
> - correct newly create dts files
> 


> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10.dts
> new file mode 100644
> index 000000000000..5a58e94c228e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10.dts
> @@ -0,0 +1,30 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Google Lazor board device tree source
> + *
> + * Copyright 2023 Google LLC.
> + */
> +
> +/dts-v1/;
> +
> +#include "sc7180-trogdor.dtsi"
> +#include "sc7180-trogdor-parade-ps8640.dtsi"
> +#include "sc7180-trogdor-lazor.dtsi"
> +#include "sc7180-lite.dtsi"
> +
> +/ {
> +	model = "Google Lazor (rev10+)";
> +	compatible = "google,lazor", "qcom,sc7180";
> +};
> +
> +&alc5682 {
> +	compatible = "realtek,rt5682s";
> +	/delete-property/ VBAT-supply;

No, don't delete properties. First of all, why you do not have this
supply here? I doubt it... Especially that this DTS has vbat-supply
regulator!

Second, define the properties where applicable instead.

> +	realtek,dmic1-clk-pin = <2>;
> +	realtek,dmic-clk-rate-hz = <2048000>;
> +};
> +
> +&sound {
> +	compatible = "google,sc7180-trogdor";
> +	model = "sc7180-rt5682s-max98357a-1mic";
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts
> index 960f7b7ce094..f74a1985cac6 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts
> @@ -13,8 +13,8 @@
>  #include "sc7180-lite.dtsi"
>  
>  / {
> -	model = "Google Lazor (rev9+) with KB Backlight";
> -	compatible = "google,lazor-sku2", "qcom,sc7180";
> +	model = "Google Lazor (rev9) with KB Backlight";
> +	compatible = "google,lazor-rev9-sku2", "qcom,sc7180";
>  };
>  
>  &keyboard_backlight {
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts
> index 438ab9cd3389..15dcf95da311 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts
> @@ -13,8 +13,8 @@
>  #include "sc7180-trogdor-lte-sku.dtsi"
>  
>  / {
> -	model = "Google Lazor (rev9+) with LTE";
> -	compatible = "google,lazor-sku0", "google,lazor-sku10", "qcom,sc7180";
> +	model = "Google Lazor (rev9) with LTE";
> +	compatible = "google,lazor-rev9-sku0", "google,lazor-rev9-sku10", "qcom,sc7180";


This is not what your binding is saying. You just introduced new
dtbs_check warnings :(

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).


Best regards,
Krzysztof