Re: [PATCH] serial: sprd: Support 12 uart ports

From: Baolin Wang
Date: Mon Aug 07 2023 - 04:41:52 EST




On 8/7/2023 4:07 PM, Wenhua Lin wrote:
From: Wenhua Lin <wenhua.lin@xxxxxxxxxx>

Support 12 uart ports, which can solve the problem
of insufficient uart ports.

This sounds incorrect to me.
If this is a software bug, please add a Fixes tag to backport for stable kernels. If the change of the max ports is only avaliable on the new SPRD serial hardware, you should ensure the change is backward-compatibility with old hardware.

Signed-off-by: Wenhua Lin <wenhua.lin@xxxxxxxxxx>
---
drivers/tty/serial/sprd_serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c
index b58f51296ace..2774df490899 100644
--- a/drivers/tty/serial/sprd_serial.c
+++ b/drivers/tty/serial/sprd_serial.c
@@ -22,7 +22,7 @@
#include <linux/tty_flip.h>
/* device name */
-#define UART_NR_MAX 8
+#define UART_NR_MAX 12
#define SPRD_TTY_NAME "ttyS"
#define SPRD_FIFO_SIZE 128
#define SPRD_DEF_RATE 26000000