Re: [PATCH v1 00/12] HID: cp2112: Cleanups and refactorings
From: Jiri Kosina
Date: Mon Aug 07 2023 - 07:34:14 EST
On Fri, 4 Aug 2023, Andy Shevchenko wrote:
> On Thu, Jul 27, 2023 at 09:43:29PM +0300, Andy Shevchenko wrote:
> > On Mon, Jul 03, 2023 at 09:52:10PM +0300, Andy Shevchenko wrote:
> > > After I updated GPIO library for the case Benjamin has with CP2112,
> > > I have a brief look into the CP2112 driver itself.
> > >
> > > From GPIO perspective it has two main (maitenance) issues:
> > > - usage of ->to_irq() with IRQ chip present;
> > > - having IRQ chip not immutable.
> > >
> > > Besides that there are plenty small cleanups here and there.
> > > Hence this series.
> >
> > Any comments on this?
>
> Gentle ping^2 for this...
>
> Anything should I do to improve it or is it okay to go as is?
I have been off pretty much the whole July. I am now back and slowly
making my way through everything that accumulated, I will eventually get
to this.
Thanks for the patience,
--
Jiri Kosina
SUSE Labs