Re: [PATCH 0/8] hp-bioscfg: Overall fixes and code cleanup

From: Hans de Goede
Date: Mon Aug 07 2023 - 07:44:00 EST


Hi,

On 7/31/23 22:31, Jorge Lopez wrote:
> Submit individual patches to address memory leaks and uninitialized
> variable errors.
> Addressed several review comments making the source code more readable.
> Removed duplicate use of variable in inner loop.
>
> Changes were tested with a HP EliteBook x360 1030 G3
>
> Jorge Lopez (8):
> hp-bioscfg: Fix memory leaks in attribute packages
> hp-bioscfg: Fix uninitialized variable errors
> hp-bioscfg: Replace the word HACK from source code
> hp-bioscfg: Change how prerequisites size is evaluated
> hp-bioscfg: Change how order list size is evaluated
> hp-bioscfg: Change how enum possible values size is evaluated
> hp-bioscfg: Change how password encoding size is evaluated
> hp-bioscfg: Remove duplicate use of variable in inner loop
>
> .../x86/hp/hp-bioscfg/enum-attributes.c | 24 ++++++++----
> .../x86/hp/hp-bioscfg/int-attributes.c | 15 +++++--
> .../x86/hp/hp-bioscfg/order-list-attributes.c | 39 ++++++++++++-------
> .../x86/hp/hp-bioscfg/passwdobj-attributes.c | 27 +++++++++----
> .../x86/hp/hp-bioscfg/string-attributes.c | 13 +++++--
> 5 files changed, 82 insertions(+), 36 deletions(-)

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans