Re: [PATCH 00/10] mtd: rawnand: qcom: Bunch of fixes and cleanups

From: Manivannan Sadhasivam
Date: Mon Aug 07 2023 - 07:50:35 EST


On Sun, Aug 06, 2023 at 03:53:09PM +0200, Miquel Raynal wrote:
> Hi Manivannan,
>
> manivannan.sadhasivam@xxxxxxxxxx wrote on Sat, 5 Aug 2023 23:11:36
> +0530:
>
> > Hi Miquel,
> >
> > This series has fixes for the smatch warnings reported by Kbuild bot [1]
> > and also several cleanup patches based on my code observation.
> >
> > I've only compile tested this series. So let's wait for Sadre/Sricharan to
> > give a tested-by tag to make sure I didn't mess up anything.
>
> I reviewed all the patches, they look good to me. I'm waiting for the
> tests. Please provide the output of nandbiterrs -i.
>

I tested the series on Qcom SDX55 based dev board, but it was broken already due
to commit <3fc92384b654> ("mtd: rawnand: qcom: Implement exec_op()").

I'm seeing a string of this error while the partitions were being enumerated:
qcom-nandc 1b30000.nand-controller: failed to copy last codeword

It just goes on...

Sadre, on what platform did you test 3fc92384b654? From a quick look, the BAM
DMA transactions are timing out.

- Mani

> Thanks,
> Miquèl

--
மணிவண்ணன் சதாசிவம்