Re: [PATCH] spi: gxp: removed unneeded call to platform_set_drvdata()

From: Mark Brown
Date: Mon Aug 07 2023 - 09:28:30 EST


On Mon, Aug 07, 2023 at 04:02:17PM +0300, Andrei Coardos wrote:

> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.

That isn't enough of a check here - people can still reference the
driver data without going through the accessor function.

Attachment: signature.asc
Description: PGP signature