Re: [PATCH] uas: Add US_FL_NO_ATA_1X for linux tcm_usb_gadget

From: Alan Stern
Date: Mon Aug 07 2023 - 09:43:42 EST


On Mon, Aug 07, 2023 at 05:50:25PM +0530, Piyush Mehta wrote:
> The linux kernel's tcm_usb_gadget requires the US_FL_NO_ATA_1X quirk.
> It does not respond to the ATA_12 family of commands and hangs. The host

Are you certain of that? Doesn't this depend on the underlying device
that the gadget is attached to?

> prevents the issuing of ATA_12 commands to the TCM module, by introducing
> this quirk, the host is permitted to proceed with other operations.

Rather than changing just one host (the Linux one) while leaving all
other hosts to malfunction, why not fix the gadget instead? Change it
so that it _doesn't_ hang when it gets an ATA_12 command but returns an
appropriate error status. That way the gadget will work with all hosts.

Alan Stern