Re: [PATCH v1 3/3] EDAC/amd64: Add support for AMD Family 1Ah Models 00h-1Fh and 40h-4Fh

From: Yazen Ghannam
Date: Mon Aug 07 2023 - 09:48:44 EST


On 8/4/2023 12:03 PM, Limonciello, Mario wrote:


On 8/3/2023 7:25 PM, Yazen Ghannam wrote:
On 7/6/2023 1:13 PM, Avadhut Naik wrote:
From: Avadhut Naik <Avadhut.Naik@xxxxxxx>

Add the necessary support in the module for AMD's new Family 1Ah-based
models 00h-1Fh and 40h-4Fh.


The first patch in this set adds PCI IDs for models starting at 20h. And this patch adds support for models 40h-4Fh.

Can you please elaborate on the discrepancy?

Thanks,
Yazen


Model 40h-4fh shares some of the same design as some other platforms.

The root port ID PCI_DEVICE_ID_AMD_19H_M60H_ROOT and DF_F3 ID PCI_DEVICE_ID_AMD_19H_M60H_DF_F3 covers it.

That's fair. Can these details be included in the commit message?

Thanks,
Yazen