Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

From: Herve Codina
Date: Mon Aug 07 2023 - 10:36:50 EST


Hi Linus, Andrew,

On Mon, 7 Aug 2023 15:17:11 +0200
Andrew Lunn <andrew@xxxxxxx> wrote:

> On Mon, Aug 07, 2023 at 03:06:42PM +0200, Linus Walleij wrote:
> > On Mon, Aug 7, 2023 at 3:05 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> >
> > > > Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>
> > >
> > > So it is a bridge chip? Please use that terminology since Linux
> > > DRM often talks about bridges.
> >
> > Replying to self: no it's not a bridge, it's a WAN thingy.
> >
> > So perhaps write that this is a WAN interface adapter chip.
>
> Hi Linus
>
> In the E1/T1/J1 world, framer is a well understood concept. Maybe the
> text needs a bit more background information to explain what this is
> to somebody who does not have an old school telecoms background.
>
> Andrew

Maybe I can add in my commit log:
--- 8< ---
This kind of component can be found in old telecommunication system.
It was used to digital transmission of many simultaneous telephone calls
by time-division multiplexing. Also using HDLC protocol, WAN networks
can be reached through the framer.
--- 8< ---

Do you think it will be better ?

Regards,
Hervé Codina

--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com