Re: [PATCH v2 2/7] dt-bindings: leds: leds-qcom-lpg: Add support for LPG PPG

From: Anjelique Melendez
Date: Mon Aug 07 2023 - 16:03:31 EST




On 8/2/2023 5:25 PM, Rob Herring wrote:
> On Tue, Jul 25, 2023 at 12:34:18PM -0700, Anjelique Melendez wrote:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,pm8350c-pw
>> + - qcom,pm8550-pwm
>> + then:
>> + properties:
>> + nvmem:
>> + minItems: 2
>> + nvmem-names:
>> + items:
>> + - const: lpg_chan_sdam
>> + - const: lut_sdam
>
> This can go into the main section and then here you just say
> 'minItems: 2'. And similar for the 1st if/then.
>
ACK
>> + required:
>> + - nvmem
>> + - nvmem-names
>
> Looks like these are always required.
These are only required for the compatibles properties that do not
have lut peripherals. Right now this is is only for qcom,pmi632-lpg,
qcom,pm8350c-pwm and qcom,pm8550-pwm.