RE: [PATCH v2 2/3] PCI/AER: Export pcie_aer_is_native()
From: Dan Williams
Date: Mon Aug 07 2023 - 23:21:26 EST
Smita Koralahalli wrote:
> Export and move the declaration of pcie_aer_is_native() to a common header
> file to be reused by cxl/pci module.
>
> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@xxxxxxx>
> Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> ---
> v2:
> Fixed $SUBJECT
> ---
> drivers/pci/pcie/aer.c | 1 +
> drivers/pci/pcie/portdrv.h | 2 --
> include/linux/aer.h | 2 ++
> 3 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index f6c24ded134c..87d90dbda023 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -229,6 +229,7 @@ int pcie_aer_is_native(struct pci_dev *dev)
>
> return pcie_ports_native || host->native_aer;
> }
> +EXPORT_SYMBOL_GPL(pcie_aer_is_native);
I would put this in the CXL symbol namespace since no other driver has
any business using this. Only the CXL subsystem, which is forced by the
specification to take on some PCI core work in its endpoint driver,
needs this export.
Otherwise, looks good to me.