Re: [PATCH V9 04/23] mmc: core: Extend support for mmc regulators with a vqmmc2

[Ulf Hansson]

On Fri, 21 Jul 2023 at 12:14, Victor Shih <victorshihgli@xxxxxxxxx> wrote:
>
> From: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>
> Updates in V4:
>  - Moved the voltage defines into this patch.
>
> Update in previous version:

Please drop the version information from the commit message.

> To allow an additional external regulator to be controlled by an mmc host
> driver, let's add support for a vqmmc2 regulator to the mmc core.
>
> For an SD UHS-II interface the vqmmc2 regulator may correspond to the so
> called vdd2 supply, as described by the SD spec. Initially, only 1.8V is
> needed, hence limit the new helper function, mmc_regulator_set_vqmmc2() to
> this too.
>
> Note that, to allow for flexibility mmc host drivers need to manage the
> enable/disable of the vqmmc2 regulator themselves, while the regulator is
> looked up through the common mmc_regulator_get_supply().
>
> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

[...]

Kind regards
Uffe