Re: [PATCH] dt-bindings: remoteproc: pru: Add Interrupt property
From: Krzysztof Kozlowski
Date: Tue Aug 08 2023 - 12:55:04 EST
On 08/08/2023 11:44, Md Danish Anwar wrote:
>>> properties:
>>> compatible:
>>> @@ -171,6 +181,9 @@ examples:
>>> <0x22400 0x100>;
>>> reg-names = "iram", "control", "debug";
>>> firmware-name = "am65x-pru0_0-fw";
>>> + interrupt-parent = <&icssg0_intc>;
>>> + interrupts = <16 2 2>;
>>> + interrupt-names = "vring";
>>> };
>>
>> These examples would probably be more helpful if they used the
>> appropriate defines, no?
>>
>
> PRUSS Interrupt controller doesn't have any appropriate defines. This doesn't
> use GIC so defines from arm-gic.h can not be used here. These are specific to
> PRUSS INTC.
>
> I think these example are OK. Please let me know if this is OK to you.
But isn't "2" type of the interrupt?
Best regards,
Krzysztof