Re: [PATCH v3] sparc: Use shared font data
From: Sam Ravnborg
Date: Tue Aug 08 2023 - 16:48:13 EST
On Tue, Aug 08, 2023 at 08:51:16AM -0700, Randy Dunlap wrote:
>
>
> On 8/6/23 18:09, linux@xxxxxxxxxxx wrote:
> > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> >
> > sparc has a 'btext' font used for the console which is almost identical
> > to the shared font_sun8x16, so use it rather than duplicating the data.
> >
> > They were actually identical until about a decade ago when
> > commit bcfbeecea11c ("drivers: console: font_: Change a glyph from
> > "broken bar" to "vertical line"")
> >
> > which changed the | in the shared font to be a solid
> > bar rather than a broken bar. That's the only difference.
> >
> > This was originally spotted by PMD which noticed that PPC does
> > the same thing with the same data, and they also share a bunch
> > of functions to manipulate the data.
> >
> > Tested very lightly with a boot without FS in qemu.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
>
> This survives lots of build testing with no problems, so
>
> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
In that case:
Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>