Re: [PATCH] selftests/mm: FOLL_LONGTERM need to be updated to 0x100

[John Hubbard]

On 8/8/23 05:43, Ayush Jain wrote:
...
> diff --git a/tools/testing/selftests/mm/hmm-tests.c b/tools/testing/selftests/mm/hmm-tests.c
> index 4adaad1b822f..20294553a5dd 100644
> --- a/tools/testing/selftests/mm/hmm-tests.c
> +++ b/tools/testing/selftests/mm/hmm-tests.c
> @@ -57,9 +57,14 @@ enum {
>   
>   #define ALIGN(x, a) (((x) + (a - 1)) & (~((a) - 1)))
>   /* Just the flags we need, copied from mm.h: */
> +
> +#ifndef FOLL_WRITE
>   #define FOLL_WRITE	0x01	/* check pte is writable */
> -#define FOLL_LONGTERM   0x10000 /* mapping lifetime is indefinite */
> +#endif
>   
> +#ifndef FOLL_LONGTERM
> +#define FOLL_LONGTERM   0x100 /* mapping lifetime is indefinite */
> +#endif
>   FIXTURE(hmm)
>   {
>   	int		fd;


Yes, it's unfortunate that this selftest framework prevents easily
including those FOLL_* flags directly.

Anyway, thanks for fixing this,

Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx>


thanks,
--
John Hubbard
NVIDIA