Re: [PATCH v2] Makefile.extrawarn: enable -Wmissing-variable-declarations for W=1

[Nathan Chancellor]

On Tue, Aug 08, 2023 at 09:17:07AM -0700, Nathan Chancellor wrote:
> I think the register storage issue should be resolved in at least clang
> before this patch is accepted, as that seems to be where the majority of
> warnings are coming from so far. Like we talked about, I'll take a shot
> at fixing that. Once that is fixed, I'll build mainline with
> -Wmissing-variable-declarations to see how many instances there are and
> if there are any other interesting edge cases that should be fixed in
> the compiler. After that, I think this should be good to go in. Does
> that sound reasonable?

I don't think there are any other edge cases from the brief glance I
gave my build logs but my matrix counts 700+ unique instances of this
(give or take some, due to interleaving issues). Quite a few but I see
several in certain files so it might not actually be too bad.

Cheers,
Nathan